Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick 76cb1cc32baa from chromium #27750

Merged
merged 2 commits into from
Feb 17, 2021

Conversation

nornagon
Copy link
Member

Use a copy for transferring non detachable buffers

Currently, |DOMArrayBuffer::Transfer()| makes a copy, but still uses
the original buffer for transferring, thus making it possible to share a
regular ArrayBuffer (not SAB) with multiple threads.

(cherry picked from commit 0d289da12075592372940a366ad565b9a13d57ce)

Bug: 1177341
Change-Id: Idb48deb1698fe555f32531bc04b55dd3e1fb0a06
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2690630
Reviewed-by: Bill Budge bbudge@chromium.org
Reviewed-by: Andreas Haas ahaas@chromium.org
Reviewed-by: Daniel Cheng dcheng@chromium.org
Commit-Queue: Sergei Glazunov glazunov@google.com
Commit-Queue: Daniel Cheng dcheng@chromium.org
Cr-Original-Commit-Position: refs/heads/master@{#853272}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2691251
Reviewed-by: Krishna Govind govind@chromium.org
Commit-Queue: Krishna Govind govind@chromium.org
Cr-Commit-Position: refs/branch-heads/4389@{#980}
Cr-Branched-From: 9251c5db2b6d5a59fe4eac7aafa5fed37c139bb7-refs/heads/master@{#843830}

Notes: Security: backported fix for 1177341.

@nornagon nornagon requested a review from a team as a code owner February 17, 2021 00:14
@nornagon nornagon added 11-x-y backport-check-skip Skip trop's backport validity checking semver/patch backwards-compatible bug fixes labels Feb 17, 2021
@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours and removed new-pr 🌱 PR opened in the last 24 hours labels Feb 17, 2021
@codebytere codebytere merged commit 5d64c42 into 11-x-y Feb 17, 2021
@release-clerk
Copy link

release-clerk bot commented Feb 17, 2021

Release Notes Persisted

Security: backported fix for 1177341.

@codebytere codebytere deleted the cherry-pick/11-x-y/chromium/76cb1cc32baa branch February 17, 2021 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
11-x-y backport-check-skip Skip trop's backport validity checking semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants